Fix FP S6759 (prefer-read-only-props): Restrict the scope to functional components
#4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
i4175
branch
from
8ede69e
to
51c6b5a
Compare
…onal components
yassin-kammoun-sonarsource
force-pushed
the
i4175
branch
from
51c6b5a
to
85d41f8
Compare
Comment on lines
+82
to
+83
| context.report({ | ||
| node: props, |
There was a problem hiding this comment.
Not sure whether we should report on the whole parameter or only on the type annotation. WDYT ?
There was a problem hiding this comment.
IMHO whole parameter is ok
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4175