Add sanity check on adding a new rule property #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
sanity-check
branch
from
4a328ec
to
f15515d
Compare
| @@ -64,6 +67,23 @@ void rules_default_is_empty() | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
| * This test raises awareness of the consequence of a rule adding or removing a rule property. | |||
| * If a new rule property is added, we should inform the SonarCloud team about it on release. | |||
There was a problem hiding this comment.
maybe link to some process on how to contact them?
There was a problem hiding this comment.
There are none. That should be email communication in my opinion.
There was a problem hiding this comment.
And I also mentioned this in our release procedures.
|
SonarQube Quality Gate
|
hashicorp-vault-sonar-prod
bot
assigned yassin-kammoun-sonarsource and unassigned ilia-kebets-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.