Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule S6819 (jsx-a11y/prefer-tag-over-role): Prefer tag over ARIA role #4267

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

alex-sonar
Copy link
Contributor

Fixes #4242

@alex-sonar alex-sonar marked this pull request as ready for review October 12, 2023 14:05
"ant-design:components/alert/__tests__/index.test.tsx": [
91
],
"ant-design:components/divider/index.tsx": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rule might be noisy on Peach, since there are already quite a few results in the ruling tests.

Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise LGTM!

@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alex-sonar alex-sonar merged commit 846ee54 into master Oct 13, 2023
13 checks passed
@alex-sonar alex-sonar deleted the issue-4242 branch October 13, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rule S6819 (jsx-a11y/prefer-tag-over-role): Prefer tag over ARIA role
2 participants