Ignore file size limits for CSS #4316
Conversation
...in/src/test/java/org/sonar/plugins/javascript/filter/JavaScriptExclusionsFileFilterTest.java
Show resolved
Hide resolved
| @@ -180,6 +180,9 @@ void should_exclude_huge_files() { | |||
| assertThat(filter.accept(inputFile("name.java", syntheticJavaFileContent(size, "Foo")))) | |||
| .withFailMessage("Wrong result for size " + size) | |||
| .isTrue(); | |||
|
|
|||
| // we ignore size limits for CSS files | |||
| assertThat(filter.accept(inputFile("name.css", syntheticJsFileContent(size)))).isTrue(); | |||
There was a problem hiding this comment.
I reused syntheticJsFileContent(), because the file content doesn't matter here.
|
I would keep assessors agnostic of the language of the file. We should create different set of assessors for CSS and JS/TS files, and simply not include size assessor in the CSS files. Keep in mind that the order of "assessing" matters -> we should do cheap exclusions based on file properties before touching the content of the file. |
|
SonarQube Quality Gate
|
|
I was wondering if it is problematic that the filter scope is only covering CssLanguage here contrary to how the CSSRuleSensor filters it. |
IMO, it's okay like this. We don't need to filter |
Fixes #4234