Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S3800 (function-return-type): Make the exception of returning at least one this instead of all this #4320

Merged
merged 2 commits into from Oct 27, 2023
Merged

Fix FP S3800 (function-return-type): Make the exception of returning at least one this instead of all this #4320

merged 2 commits into from Oct 27, 2023

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

Fixes #4251

@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title make exception if at least one return is this Fix FP S3800 (function-return-type): Make the exception of returning *at least one* this (instead of *all* this) Oct 26, 2023
@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title Fix FP S3800 (function-return-type): Make the exception of returning *at least one* this (instead of *all* this) Fix FP S3800 (function-return-type): Make the exception of returning at least one this instead of all this Oct 26, 2023
@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit e97f8d1 into master Oct 27, 2023
16 checks passed
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the issue-4251/S3800-function-return-type-at-least-one-this branch October 27, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP S3800 (function-return-type): Make the exception of returning "this" work
2 participants
@ilia-kebets-sonarsource @yassin-kammoun-sonarsource