Create rule CSS:S125: Sections of code should not be commented out #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
i4227
branch
from
dfd66e4
to
ae070ad
Compare
vdiez
approved these changes
Oct 31, 2023
| }); | ||
| }; | ||
|
|
||
| function isLikelyCss(text: string) { |
There was a problem hiding this comment.
would be nice to have an example of what each regex is trying to match, next to the description
There was a problem hiding this comment.
👍
|
92.3% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4227
Relying solely on regular expressions to detect commented-out CSS code wasn't reliable. All issues raised on ruling were false positives. Therefore, I adopted the same approach with took with the implementation for JavaScript: