Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify S4328: Use new package.json shared methods #4377

Merged
merged 9 commits into from Nov 14, 2023
Merged

Modify S4328: Use new package.json shared methods #4377

merged 9 commits into from Nov 14, 2023

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Nov 14, 2023

Fixes #4367

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/yaml/tests/parser/parse.test.ts Outdated Show resolved Hide resolved
packages/yaml/tests/aws/parser.test.ts Outdated Show resolved Hide resolved
packages/yaml/tests/analysis/analyzer.test.ts Outdated Show resolved Hide resolved
packages/shared/src/index.ts Show resolved Hide resolved
packages/jsts/tests/parsers/parse.test.ts Outdated Show resolved Hide resolved
packages/jsts/tests/parsers/parse.test.ts Outdated Show resolved Hide resolved
packages/jsts/tests/builders/build.test.ts Outdated Show resolved Hide resolved
packages/jsts/tests/builders/build.test.ts Outdated Show resolved Hide resolved
packages/jsts/tests/analysis/analyzer.test.ts Outdated Show resolved Hide resolved
packages/jsts/tests/analysis/analyzer.test.ts Outdated Show resolved Hide resolved
@vdiez vdiez enabled auto-merge (squash) November 14, 2023 20:16
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@vdiez vdiez merged commit 2be9541 into master Nov 14, 2023
14 checks passed
@vdiez vdiez deleted the modify-S4328 branch November 14, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S4328: Do not search for package.json files. Rely on getPackageJsonsForFile
2 participants
@vdiez @yassin-kammoun-sonarsource