Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD-4131 use GitHub token from vault instead of sonartech api token #4386

Merged
merged 2 commits into from
Nov 16, 2023
Merged

BUILD-4131 use GitHub token from vault instead of sonartech api token #4386

merged 2 commits into from
Nov 16, 2023
+18 −10

Conversation

sebastienvermeille
Copy link
Contributor

@sebastienvermeille sebastienvermeille commented Nov 14, 2023 •
edited
Loading

BUILD-4131 use GitHub token from vault instead of sonartech api token

Changes

  • Adapt the dogfood pipeline
    That way this secret can be rotated easily as it comes from Vault

Depends on

@sebastienvermeille sebastienvermeille self-assigned this Nov 14, 2023
@sebastienvermeille @matemoln
Update .github/workflows/dogfood.yml
b4e3728 
Co-authored-by: Mate Molnar <matemoln@users.noreply.github.com>
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@sebastienvermeille sebastienvermeille marked this pull request as ready for review November 16, 2023 08:21
@sebastienvermeille sebastienvermeille merged commit 6fbcb4e into master Nov 16, 2023
22 checks passed
@sebastienvermeille sebastienvermeille deleted the feature/svermeille/BUILD-4131-Use-GitHub-token-from-Vault-instead-of-sonartech-api-token branch November 16, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matemoln matemoln matemoln approved these changes

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees

@sebastienvermeille sebastienvermeille

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebastienvermeille @matemoln @yassin-kammoun-sonarsource