Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6847 (jsx-a11y/no-noninteractive-element-interactions): Non-interactive elements shouldn't have event handlers #4388

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Create rule S6847 (jsx-a11y/no-noninteractive-element-interactions): Non-interactive elements shouldn't have event handlers #4388

merged 6 commits into from
Nov 16, 2023

Conversation

saberduck
Copy link
Contributor

@saberduck saberduck commented Nov 15, 2023 •
edited by ilia-kebets-sonarsource
Loading

Fixes #4285

ilia-kebets-sonarsource
ilia-kebets-sonarsource reviewed Nov 15, 2023
View reviewed changes
its/sources/jsts/custom/S6847.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this one since we have occurrences in the ruling projects?

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to remove the custom ruling file since the new rule raises issues in the other projects.
This would require removing the expected issues it raised.

@saberduck saberduck enabled auto-merge (squash) November 16, 2023 14:08
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@saberduck saberduck merged commit 69a1e0f into master Nov 16, 2023
14 checks passed
@saberduck saberduck deleted the i4285 branch November 16, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees

@ilia-kebets-sonarsource ilia-kebets-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create rule S6847 (jsx-a11y/no-noninteractive-element-interactions)
2 participants
@saberduck @ilia-kebets-sonarsource