Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve S1874 (deprecation): Remove references from React no-deprecated messages #4392

Merged
merged 2 commits into from Nov 16, 2023

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Nov 16, 2023

No description provided.

@vdiez vdiez added this to the 10.10 milestone Nov 16, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Remove references from React no-deprecated messages Improve S1874 (deprecation): Remove references from React no-deprecated messages Nov 16, 2023
Copy link
Contributor

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update a comment-based fixture and add an assertion with the reworked message.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@vdiez vdiez merged commit d77645d into master Nov 16, 2023
16 checks passed
@vdiez vdiez deleted the fix-S1874 branch November 16, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants