Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S1444: Public "static" fields should be read-only #4453

Merged
merged 1 commit into from Dec 5, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4424

Copy link

sonarqube-next bot commented Dec 4, 2023

@@ -0,0 +1,3 @@
class S1444 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this file because ruling didn't raise anything on all the projects during my first run. But for some reason, issues started to pop up afterward.

I think it doesn't hurt to keep this file, it's just yet another issue.

Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 76a783a into master Dec 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rule S1444: Public "static" fields should be read-only
2 participants