Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S6594 (sonar-prefer-regexp-exec): Ignore match count use case #4540

Merged
merged 3 commits into from Jan 31, 2024
Merged

Fix FP S6594 (sonar-prefer-regexp-exec): Ignore match count use case #4540

merged 3 commits into from Jan 31, 2024

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4532

ilia-kebets-sonarsource
ilia-kebets-sonarsource reviewed Jan 31, 2024
View reviewed changes
packages/jsts/src/rules/S6594/rule.ts
* Extracts the left-hand side variable of expressions
* like `x` in `const x = <node>` or `x` in `x = <node>`.
*/
function getLhsVariable(node: estree.Node) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it the same as https://sonarsource.github.io/SonarJS/typedoc/functions/getLhsVariable.html ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, I forgot to replace this one with my implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I think I will keep my duplicate because the function signature is a bit different, and I am not sure I would like to merge both and impact other rules.

@yassin-kammoun-sonarsource @ilia-kebets-sonarsource
Update packages/jsts/src/rules/S6594/cb.fixture.js
161c143 
Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource
Update packages/jsts/src/rules/S6594/cb.fixture.js
b12d821 
Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments, otherwise LGTM!

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 9cdfd47 into master Jan 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP S6594 (sonar-prefer-regexp-exec): Ignore match count use case
2 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource