Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve synchronization between Node.js parent process and worker thread #4603

Merged
merged 11 commits into from Mar 25, 2024
Merged

Improve synchronization between Node.js parent process and worker thread #4603

merged 11 commits into from Mar 25, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Mar 20, 2024

Fixes #4580

zglicz
zglicz approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some questions

packages/bridge/tests/router.test.ts Outdated Show resolved Hide resolved
packages/bridge/tests/server.test.ts Show resolved Hide resolved
packages/tsconfig.json Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@vdiez vdiez merged commit 9d4edb2 into master Mar 25, 2024
15 checks passed
@vdiez vdiez deleted the sync-workers branch March 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zglicz zglicz zglicz approved these changes

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource Awaiting requested review from yassin-kammoun-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve synchronization between Node.js parent process and worker thread
2 participants
@vdiez @zglicz