Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #4631: Fix FP S2699 (assertions-in-tests): Add support for supertest #4636

Merged

Conversation

ericmorand-sonarsource
Copy link
Contributor

Fixes #4631

Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementations looks good, could you add a custom ruling file to verify the change in an integration test?

Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit 32b63dd into SonarSource:master Mar 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix FP S2699 (assertions-in-tests): Add support for supertest
2 participants