Remove usage of deprecated APIs #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @SonarLintSide(lifespan = MULTIPLE_ANALYSES) | ||
| @SonarLintSide(lifespan = INSTANCE) |
There was a problem hiding this comment.
Is INSTANCE the replacement for the deprecated MULTIPLE_ANALYSES?
There was a problem hiding this comment.
yes, you can check the javadoc
Comment on lines
-180
to
+179
| PROFILER.startDebug("Starting server"); | ||
| LOG.debug("Starting server"); | ||
| long start = System.currentTimeMillis(); |
There was a problem hiding this comment.
Is there no equivalent for Profiler in slf4j?
There was a problem hiding this comment.
unfortunately no, if really needed we can create something similar on our own
ilia-kebets-sonarsource
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4641