This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
Replace implementation of S4136 with 'consecutive-overloads' rule in sonarts #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
saberduck
force-pushed
the
issue-469
branch
2 times, most recently
from
09d77cf
to
979a7e6
Compare
vilchik-elena
approved these changes
May 17, 2018
| options: null, | ||
| rspecKey: "RSPEC-4136", | ||
| type: "functionality", | ||
| typescriptOnly: false, |
| optionsDescription: "", | ||
| options: null, | ||
| rspecKey: "RSPEC-4136", | ||
| type: "functionality", |
There was a problem hiding this comment.
@saberduck maintanability
| @@ -233,3 +233,7 @@ export function isVariableStatement(node: ts.Node): node is ts.VariableStatement | |||
| export function isUnionOrIntersectionTypeNode(node: ts.Node): node is ts.UnionOrIntersectionTypeNode { | |||
| return is(node, ts.SyntaxKind.UnionType, ts.SyntaxKind.IntersectionType); | |||
| } | |||
|
|
|||
| export function isSignatureDeclaration(node: ts.Node): node is ts.SignatureDeclaration { | |||
| return "parameters" in node; | |||
There was a problem hiding this comment.
@saberduck hm, is it reliable?
There was a problem hiding this comment.
in the original implementation was something equivalent, they use this https://github.com/ajafff/tsutils/blob/master/typeguard/node.ts#L579
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469