Export "meta" for plugin #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -25,7 +25,7 @@ import lodash from 'lodash'; | |||
| import minimist from 'minimist'; | |||
| import sonarjs from '../src'; | |||
|
|
|||
| const rulesPath = path.join(__dirname, '../lib/rules'); | |||
| const rulesPath = path.join(__dirname, '../lib/src/rules'); | |||
There was a problem hiding this comment.
Out of curiosity, how was it working before this change?
There was a problem hiding this comment.
This is due to the "resolveJSONModule": true in the tsconfig. I think it's due to this, we need to pull in the package.json into the generated 'lib' folder and everything is then a level deeper within 'lib/src'
before: 'lib/rules', 'lib/utils' <- no package.json
after: 'lib/package.json', 'lib/src/rules', 'lib/src/utils'
ericmorand-sonarsource
approved these changes
May 6, 2024
renovate bot
added a commit
to ScaleLeap/amazon-marketplaces
that referenced
this pull request
May 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs) | [`0.25.1` -> `1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>SonarSource/eslint-plugin-sonarjs (eslint-plugin-sonarjs)</summary> ### [`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...004d7944672f249000e1eb1c97acd13e31e455eb) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3) ### [`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2) #### What's Changed - Export "meta" for plugin by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#472 ### [`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0) Eslint-plugin-sonarjs is compatible with ESLint v9. ##### What's Changed - Migrate to all newest packages, except for eslint v9 by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#460 - Move from a compile-all to a compile-entry-point pattern by [@​ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#463 - ESLINTJS-36 Split out tests and analyze into separate steps by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#465 - Fix breaking no-one-iteration-loop after ESLint v9 breaking change by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#467 - Resolve ESLINTJS-37 by [@​ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#466 - Add ruling tests to handle eslint 8 and 9 by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#468 - Make the exported rules a typed record by [@​ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#469 **Full Changelog**: SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ScaleLeap/amazon-marketplaces). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOlsicmVub3ZhdGVib3QiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 9, 2024
](https://renovatebot.com){kind=link}
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ESLINTJS-40
Reading through the ESLint 9 compatibility issue tracker (eslint/eslint#18093), one of the relevant items is the "meta" object to be exporting the name and version.
Once this lands and we release, I'll post to that thread that we are ready and compatible.