Add 1st version of a simple kotlinAST -> SLangAST mapper #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pynicolas
reviewed
May 29, 2018
| import org.junit.Test; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.hamcrest.CoreMatchers.notNullValue; |
There was a problem hiding this comment.
Let's use assertj, please!
| TreeVisitor<TreeContext> visitor = new TreeVisitor<>(); | ||
| visitor.register(Tree.class, (ctx, tree) -> System.out.println(formatTree(tree))); | ||
| visitor.scan(new TreeContext(), ASTMapper.fromString("fun function1() = 2 >= 1")); | ||
| assertThat(true, is(true)); |
There was a problem hiding this comment.
What is this assertion supposed to do?
| } | ||
|
|
||
| private static PsiFile compile(String content) { | ||
| PsiFileFactory psiFileFactory = PsiFileFactory.getInstance(createKotlinCoreEnvironment()); |
There was a problem hiding this comment.
We may keep this psiFileFactory as a field if it's an expensive operation.
|
|
||
| import static java.nio.file.Files.readAllBytes; | ||
|
|
||
| public class ASTMapper { |
There was a problem hiding this comment.
Why not naming this class KotlinParser?
| return BinaryExpressionTree.Operator.CONDITIONAL_OR; | ||
| } else if (KtTokens.ANDAND.equals(operationTokenType)) { | ||
| return BinaryExpressionTree.Operator.CONDITIONAL_AND; | ||
| } |
There was a problem hiding this comment.
We now have other operators: see BinaryExpressionTree.Operator.
| } | ||
|
|
||
| private static BinaryExpressionTree.Operator mapBinaryExpression(IElementType operationTokenType) { | ||
| if (KtTokens.EQEQ.equals(operationTokenType)) { |
There was a problem hiding this comment.
Why not have a map instead of this big if statement?
christophe-zurn-sonarsource
assigned pynicolas and unassigned christophe-zurn-sonarsource
tomverin
pushed a commit
that referenced
this pull request
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.