SE: Maintenance: Unroll SymbolicCheckList.InvokeChecks (#6982)

SonarSource · Mar 24, 2023 · 0acb770 · 0acb770
1 parent 84eef23
commit 0acb770
Showing 1 changed file with 17 additions and 6 deletions.
diff --git a/analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/SymbolicCheckList.cs b/analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/SymbolicCheckList.cs
@@ -60,19 +60,30 @@ public void ExecutionCompleted()
         }
 
         public SymbolicContext[] PreProcess(SymbolicContext context) =>
-            InvokeChecks(context, (check, context) => check.PreProcess(context));
+            InvokeChecks(context, preProcess: true);
 
         public SymbolicContext[] PostProcess(SymbolicContext context) =>
-            InvokeChecks(context, (check, context) => check.PostProcess(context));
+            InvokeChecks(context, preProcess: false);
 
-        private SymbolicContext[] InvokeChecks(SymbolicContext context, Func<SymbolicCheck, SymbolicContext, ProgramState[]> process)
+        private SymbolicContext[] InvokeChecks(SymbolicContext context, bool preProcess)
         {
-            var contexts = new[] { context };
+            // Performance: Hotpath. Don't do changes here without profiling allocation impact.
+            var before = new List<SymbolicContext> { context };
+            var after = new List<SymbolicContext>();
             foreach (var check in checks)
             {
-                contexts = contexts.SelectMany(x => process(check, x).Select(newState => x.WithState(newState))).ToArray();
+                foreach (var beforeContext in before)
+                {
+                    var newStates = preProcess ? check.PreProcess(beforeContext) : check.PostProcess(beforeContext);
+                    foreach (var newState in newStates)
+                    {
+                        after.Add(beforeContext.WithState(newState));
+                    }
+                }
+                after = Interlocked.Exchange(ref before, after);
+                after.Clear();
             }
-            return contexts;
+            return before.ToArray();
         }
     }
 }