Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE: Maintenance: Unroll SymbolicCheckList.InvokeChecks #6982

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Part of #6964

@martin-strecker-sonarsource
Copy link
Contributor Author

Before: 45.7 GB allocations
After: 40.2 GB allocations

Comparison (left: before, right: after)
image

System.Func<,> was reduced from 3GB to 1.3GB. SelectManyIterator is no longer in the top list.

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Mar 24, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review March 24, 2023 09:12
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 0acb770 into feature/SE Mar 24, 2023
Best Kanban automation moved this from Review approved to Validate Peach Mar 24, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Martin/SE_6964_02_Unroll branch March 24, 2023 09:56
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from Validate Peach to Done in Best Kanban Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprint: SE Short-lived* label for epic MMF-3077 *troll
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants