Fix S1186 FP: Empty method comes from interface (#7658)

SonarSource · Jul 26, 2023 · cfbb8e1 · cfbb8e1
1 parent 6084157
commit cfbb8e1
Show file tree

Hide file tree

Showing 17 changed files with 33 additions and 617 deletions.
diff --git a/analyzers/its/expected/Nancy/Nancy--net452-S1186.json b/analyzers/its/expected/Nancy/Nancy--net452-S1186.json
@@ -4,32 +4,6 @@
 "id":  "S1186",
 "message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
 "location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Bootstrapper/FavIconApplicationStartup.cs#L46",
-"region":  {
-"startLine":  46,
-"startColumn":  21,
-"endLine":  46,
-"endColumn":  31
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Diagnostics/NullLog.cs#L15",
-"region":  {
-"startLine":  15,
-"startColumn":  21,
-"endLine":  15,
-"endColumn":  29
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
 "uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Diagnostics/TestingDiagnosticProvider.cs#L54",
 "region":  {
 "startLine":  54,
@@ -56,19 +30,6 @@
 "id":  "S1186",
 "message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
 "location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/IO/UnclosableStreamWrapper.cs#L192",
-"region":  {
-"startLine":  192,
-"startColumn":  25,
-"endLine":  192,
-"endColumn":  32
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
 "uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/IO/UnclosableStreamWrapper.cs#L319",
 "region":  {
 "startLine":  319,
@@ -77,45 +38,6 @@
 "endColumn":  40
 }
 }
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Security/CsrfApplicationStartup.cs#L37",
-"region":  {
-"startLine":  37,
-"startColumn":  21,
-"endLine":  37,
-"endColumn":  31
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/StaticContent.cs#L32",
-"region":  {
-"startLine":  32,
-"startColumn":  21,
-"endLine":  32,
-"endColumn":  31
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/ViewEngines/SuperSimpleViewEngine/SuperSimpleViewEngineWrapper.cs#L47",
-"region":  {
-"startLine":  47,
-"startColumn":  21,
-"endLine":  47,
-"endColumn":  31
-}
-}
 }
 ]
 }
diff --git a/analyzers/its/expected/Nancy/Nancy--netstandard2.0-S1186.json b/analyzers/its/expected/Nancy/Nancy--netstandard2.0-S1186.json
@@ -4,32 +4,6 @@
 "id":  "S1186",
 "message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
 "location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Bootstrapper/FavIconApplicationStartup.cs#L46",
-"region":  {
-"startLine":  46,
-"startColumn":  21,
-"endLine":  46,
-"endColumn":  31
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Diagnostics/NullLog.cs#L15",
-"region":  {
-"startLine":  15,
-"startColumn":  21,
-"endLine":  15,
-"endColumn":  29
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
 "uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Diagnostics/TestingDiagnosticProvider.cs#L54",
 "region":  {
 "startLine":  54,
@@ -56,19 +30,6 @@
 "id":  "S1186",
 "message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
 "location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/IO/UnclosableStreamWrapper.cs#L192",
-"region":  {
-"startLine":  192,
-"startColumn":  25,
-"endLine":  192,
-"endColumn":  32
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
 "uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/IO/UnclosableStreamWrapper.cs#L319",
 "region":  {
 "startLine":  319,
@@ -77,45 +38,6 @@
 "endColumn":  40
 }
 }
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/Security/CsrfApplicationStartup.cs#L37",
-"region":  {
-"startLine":  37,
-"startColumn":  21,
-"endLine":  37,
-"endColumn":  31
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/StaticContent.cs#L32",
-"region":  {
-"startLine":  32,
-"startColumn":  21,
-"endLine":  32,
-"endColumn":  31
-}
-}
-},
-{
-"id":  "S1186",
-"message":  "Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.",
-"location":  {
-"uri":  "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/ViewEngines/SuperSimpleViewEngine/SuperSimpleViewEngineWrapper.cs#L47",
-"region":  {
-"startLine":  47,
-"startColumn":  21,
-"endLine":  47,
-"endColumn":  31
-}
-}
 }
 ]
 }
diff --git a/analyzers/its/expected/Nancy/Nancy.ViewEngines.Markdown--net452-S1186.json b/analyzers/its/expected/Nancy/Nancy.ViewEngines.Markdown--net452-S1186.json
diff --git a/analyzers/its/expected/Nancy/Nancy.ViewEngines.Markdown--netstandard2.0-S1186.json b/analyzers/its/expected/Nancy/Nancy.ViewEngines.Markdown--netstandard2.0-S1186.json
diff --git a/analyzers/its/expected/Nancy/Nancy.ViewEngines.Nustache--net452-S1186.json b/analyzers/its/expected/Nancy/Nancy.ViewEngines.Nustache--net452-S1186.json
diff --git a/analyzers/its/expected/Nancy/Nancy.ViewEngines.Razor--net452-S1186.json b/analyzers/its/expected/Nancy/Nancy.ViewEngines.Razor--net452-S1186.json