Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1186 FP: Empty method comes from interface #7658

Merged
merged 9 commits into from
Jul 26, 2023
Merged

Fix S1186 FP: Empty method comes from interface #7658

merged 9 commits into from
Jul 26, 2023

Conversation

cristian-ambrosini-sonarsource
Copy link
Contributor

Fixes #7629

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource changed the base branch from master to cristian/S1186-FP July 24, 2023 15:30
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes and a question about the location of the new extension method.

analyzers/src/SonarAnalyzer.Common/Extensions/ISymbolExtensions.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/EmptyMethod.cs Outdated Show resolved Hide resolved
martin-strecker-sonarsource
martin-strecker-sonarsource reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The changes in ITs seem reasonable.

Base automatically changed from cristian/S1186-FP to master July 26, 2023 07:48
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource merged commit cfbb8e1 into master Jul 26, 2023
22 checks passed
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource deleted the cristian/Fix-S1186-FP branch July 26, 2023 09:52
@cristian-ambrosini-sonarsource
Copy link
Contributor Author

cristian-ambrosini-sonarsource commented Aug 3, 2023 •
edited
Loading

Peach validation:

  • 2596 lost FPs. I checked randomly more than 50 and they were all methods coming from an interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S1186 FP: Empty method comes from interface
3 participants
@cristian-ambrosini-sonarsource @martin-strecker-sonarsource @CristianAmbrosini