Skip to content

Commit

Permalink
Rename invocationSymbol to methodSymbol
Browse files Browse the repository at this point in the history
  • Loading branch information
costin-zaharia-sonarsource committed Feb 28, 2024
1 parent 6eaaa4c commit d2da2a3
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ private static void CheckInvalidParams(InvocationExpressionSyntax invocation, IM
}
}

private static void CheckInvalidTypeParams(InvocationExpressionSyntax invocation, IMethodSymbol invocationSymbol, SonarSyntaxNodeReportingContext c, ImmutableArray<KnownType> knownTypes)
private static void CheckInvalidTypeParams(InvocationExpressionSyntax invocation, IMethodSymbol methodSymbol, SonarSyntaxNodeReportingContext c, ImmutableArray<KnownType> knownTypes)
{
if (!IsNLogIgnoredOverload(invocationSymbol) && invocationSymbol.TypeArguments.Any(x => x.DerivesFromAny(knownTypes)))
if (!IsNLogIgnoredOverload(methodSymbol) && methodSymbol.TypeArguments.Any(x => x.DerivesFromAny(knownTypes)))
{
var typeParameterNames = invocationSymbol.TypeParameters.Select(x => x.MetadataName).ToArray();
var positions = invocationSymbol.ConstructedFrom.Parameters.Where(x => typeParameterNames.Contains(x.Type.MetadataName)).Select(x => invocationSymbol.ConstructedFrom.Parameters.IndexOf(x));
var typeParameterNames = methodSymbol.TypeParameters.Select(x => x.MetadataName).ToArray();
var positions = methodSymbol.ConstructedFrom.Parameters.Where(x => typeParameterNames.Contains(x.Type.MetadataName)).Select(x => methodSymbol.ConstructedFrom.Parameters.IndexOf(x));
var invalidArguments = InvalidArguments(invocation, c.SemanticModel, positions, knownTypes).Select(x => x.GetLocation());
c.ReportIssue(Diagnostic.Create(Rule, invocation.Expression.GetLocation(), invalidArguments));
}
Expand Down

0 comments on commit d2da2a3

Please sign in to comment.