Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TupleExpressions in CSharpExplodedGraph #2933

Closed
costin-zaharia-sonarsource opened this issue Dec 26, 2019 · 3 comments
Closed
Labels
Area: CFG/SE CFG and SE related issues.

Comments

@costin-zaharia-sonarsource
Copy link
Member

costin-zaharia-sonarsource commented Dec 26, 2019

Description

We need to add support for handling TupleExpressions in CSharpExplodedGraph.

Repro steps

Currently the TupleExpressions are just ignored when processing code like:

public class Address
{
    public string Name { get; }

    public string State { get; }

    public void Deconstruct(out string name, out string state) =>
        (name, state) = (Name, State);
}

Additional notes

Once the tuples are supported by CFG and semantic execution we need to update the DeadStores rule (S1854) and remove the check added by #3113.

costin-zaharia-sonarsource added a commit that referenced this issue Feb 12, 2020
Since the tuples are not yet fully supported by both CFG and symbolic
execution (#2933) we will ignore the methods which are containing them.
costin-zaharia-sonarsource added a commit that referenced this issue Feb 12, 2020
Since the tuples are not yet fully supported by both CFG and symbolic
execution (#2933) we will ignore the methods which are containing them.
costin-zaharia-sonarsource added a commit that referenced this issue Feb 12, 2020
Since the tuples are not yet fully supported by both CFG and symbolic
execution (#2933) we will ignore the methods which are containing them.
@andrei-epure-sonarsource
Copy link
Contributor

closing as this will be fixed with the new Roslyn CFG

@pavel-mikula-sonarsource
Copy link
Contributor

@andrei-epure-sonarsource I'd prefer to keep this documented as opened issue until we support it.

@andrei-epure-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource can we close this now?

@pavel-mikula-sonarsource pavel-mikula-sonarsource closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CFG/SE CFG and SE related issues.
Projects
None yet
Development

No branches or pull requests

3 participants