Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate S3949 to the new Symbolic Execution engine #4631

Closed
3 tasks done
costin-zaharia-sonarsource opened this issue Jul 5, 2021 · 3 comments
Closed
3 tasks done

Migrate S3949 to the new Symbolic Execution engine #4631

costin-zaharia-sonarsource opened this issue Jul 5, 2021 · 3 comments
Assignees
@Tim-Pohlmann
Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Sprint: SE Short-lived* label for epic MMF-3077 *troll Type: Improvement Making existing code better.
Projects
Backlog Best Kanban
Milestone
9.2

Comments

@costin-zaharia-sonarsource
Copy link
Member

costin-zaharia-sonarsource commented Jul 5, 2021 •
edited by pavel-mikula-sonarsource

Currently S3949 is the only rule implemented using CBDE.

The CBDE engine is no longer maintained and planned to be removed and reimplementing the rule will enable this.

This should be done on a feature branch.

ToDo:
@costin-zaharia-sonarsource costin-zaharia-sonarsource added Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Type: Improvement Making existing code better. labels Jul 5, 2021
@costin-zaharia-sonarsource costin-zaharia-sonarsource added this to Improvement in Backlog Jul 5, 2021
@costin-zaharia-sonarsource costin-zaharia-sonarsource changed the title Reimplement RSPEC-3949 to remove CBDE dependency Reimplement S3949 to remove CBDE dependency Jul 5, 2021
Merged
@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Aug 10, 2022 •
edited

CBDE deprecation was announced before 9.x LTS.

We will use the new Roslyn-based SE to implement the rule during SQ 10.x cycle.

We can drop CBDE as part of the process.

@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 9.1 milestone Apr 28, 2023
@github-actions github-actions bot added this to To do in Best Kanban Apr 28, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource added the Sprint: SE Short-lived* label for epic MMF-3077 *troll label May 1, 2023
Closed
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Reimplement S3949 to remove CBDE dependency Migrate S3949 to the new Symbolic Execution engine May 1, 2023
@Tim-Pohlmann Tim-Pohlmann mentioned this issue May 2, 2023
Merged
@Tim-Pohlmann Tim-Pohlmann linked a pull request May 2, 2023 that will close this issue
S3949: Create empty rule #7164
Merged
@Tim-Pohlmann Tim-Pohlmann moved this from To do to In progress in Best Kanban May 2, 2023
@Tim-Pohlmann Tim-Pohlmann self-assigned this May 2, 2023
Closed
@Tim-Pohlmann Tim-Pohlmann removed a link to a pull request May 4, 2023
S3949: Create empty rule #7164
Merged
@Tim-Pohlmann
Copy link
Contributor

Tim-Pohlmann commented May 11, 2023 •
edited by pavel-mikula-sonarsource

ShouldExecute should skip when the method...

@Tim-Pohlmann Tim-Pohlmann mentioned this issue May 17, 2023
Merged
@pavel-mikula-sonarsource
Copy link
Contributor

ShouldExecute will be implemented as part of #4631

Best Kanban automation moved this from In progress to Validate Peach May 23, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban May 24, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource modified the milestones: 9.1, 9.2 May 25, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Done to Validate Peach in Best Kanban May 26, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban May 31, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Done to Validate Peach in Best Kanban May 31, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Sprint: SE Short-lived* label for epic MMF-3077 *troll Type: Improvement Making existing code better.
Projects
Best Kanban
  
Done
Backlog
  
Improvement
Milestone
9.2
Development

No branches or pull requests
3 participants
@Tim-Pohlmann @costin-zaharia-sonarsource @pavel-mikula-sonarsource