Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3949: Create empty rule #7164

Merged
merged 7 commits into from
May 10, 2023
Merged

S3949: Create empty rule #7164

merged 7 commits into from
May 10, 2023

Conversation

Tim-Pohlmann
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann commented May 2, 2023 •
edited
Loading

Step 1 of #4631

@Tim-Pohlmann Tim-Pohlmann linked an issue May 2, 2023 that may be closed by this pull request
Migrate S3949 to the new Symbolic Execution engine #4631
Closed
3 tasks
@Tim-Pohlmann Tim-Pohlmann changed the title Add scaffolding for S3949 Create empty rule S3949 May 3, 2023
@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/S3949-CS branch 4 times, most recently from 732c2f4 to 138f61f Compare May 3, 2023 10:32
@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/S3949-CS branch 2 times, most recently from c510307 to ec2ab48 Compare May 4, 2023 14:45
@Tim-Pohlmann Tim-Pohlmann removed a link to an issue May 4, 2023
Migrate S3949 to the new Symbolic Execution engine #4631
Closed
3 tasks
@Tim-Pohlmann Tim-Pohlmann self-assigned this May 4, 2023
@Tim-Pohlmann Tim-Pohlmann added the Sprint: SE Short-lived* label for epic MMF-3077 *troll label May 4, 2023
@Tim-Pohlmann Tim-Pohlmann added this to In progress in Best Kanban May 4, 2023
@Tim-Pohlmann Tim-Pohlmann marked this pull request as ready for review May 4, 2023 15:15
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 4, 2023
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 :)

analyzers/src/SonarAnalyzer.CSharp/Rules/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
...onarAnalyzer.Common/SymbolicExecution/Roslyn/RuleChecks/CalculationsShouldNotOverflowBase.cs Outdated Show resolved Hide resolved
...s/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
...nalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/CalculationsShouldNotOverflow.CSharp9.cs Show resolved Hide resolved
...s/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
...s/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
...s/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/CalculationsShouldNotOverflow.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban May 5, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final polishing

...onarAnalyzer.Common/SymbolicExecution/Roslyn/RuleChecks/CalculationsShouldNotOverflowBase.cs Outdated Show resolved Hide resolved
...onarAnalyzer.Common/SymbolicExecution/Roslyn/RuleChecks/CalculationsShouldNotOverflowBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/SymbolicExecution/SymbolicExecutionRunner.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 9, 2023
@pavel-mikula-sonarsource
Copy link
Contributor

I've rebased the feature branch, you can rebase this to make the UTs green again.

@pavel-mikula-sonarsource
Copy link
Contributor

Please run the rspec script again with the latest rule-api. I assume it will update the HTML file to the education v1 format

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 79e7408 into feature/CBDE May 10, 2023
21 of 22 checks passed
Best Kanban automation moved this from Review approved to Validate Peach May 10, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Tim/S3949-CS branch May 10, 2023 07:30
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban May 10, 2023
pavel-mikula-sonarsource pushed a commit that referenced this pull request May 11, 2023
@Tim-Pohlmann @pavel-mikula-sonarsource
S3949: Create empty rule (#7164)
74d80bd
pavel-mikula-sonarsource pushed a commit that referenced this pull request May 17, 2023
@Tim-Pohlmann @pavel-mikula-sonarsource
S3949: Create empty rule (#7164)
9c340b3
pavel-mikula-sonarsource pushed a commit that referenced this pull request May 23, 2023
@Tim-Pohlmann @pavel-mikula-sonarsource
S3949: Create empty rule (#7164)
9023b5c
pavel-mikula-sonarsource pushed a commit that referenced this pull request May 26, 2023
@Tim-Pohlmann @pavel-mikula-sonarsource
S3949: Create empty rule (#7164)
d3f53b9
pavel-mikula-sonarsource pushed a commit that referenced this pull request May 26, 2023
@Tim-Pohlmann @pavel-mikula-sonarsource
S3949: Create empty rule (#7164)
f0f01e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Sprint: SE Short-lived* label for epic MMF-3077 *troll
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tim-Pohlmann @pavel-mikula-sonarsource