-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S2259 FP: Reset fields on this invocation with flow captures #6150
Merged
pavel-mikula-sonarsource
merged 21 commits into
master
from
Martin/S2259_FixResetOnInstanceMehtodWithFlowCapture
Oct 6, 2022
Merged
Fix S2259 FP: Reset fields on this invocation with flow captures #6150
pavel-mikula-sonarsource
merged 21 commits into
master
from
Martin/S2259_FixResetOnInstanceMehtodWithFlowCapture
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
requested a review
from pavel-mikula-sonarsource
September 30, 2022 12:54
pavel-mikula-sonarsource
requested changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor polishing
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/ProgramState.cs
Outdated
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IInvocationOperationExtensions.cs
Outdated
Show resolved
Hide resolved
…d capture and fix bug
martin-strecker-sonarsource
force-pushed
the
Martin/S2259_FixResetOnInstanceMehtodWithFlowCapture
branch
from
October 6, 2022 07:25
7bea59f
to
82dd6bc
Compare
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
pavel-mikula-sonarsource
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pavel-mikula-sonarsource
changed the title
S2259: FP for fields not reset on invocation on this
Fix S2259 FP: Reset fields on this invocation with flow captures
Oct 6, 2022
pavel-mikula-sonarsource
deleted the
Martin/S2259_FixResetOnInstanceMehtodWithFlowCapture
branch
October 6, 2022 10:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6103