Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S2259 FP: Reset fields on this invocation with flow captures #6150

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes #6103

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor polishing

@martin-strecker-sonarsource martin-strecker-sonarsource force-pushed the Martin/S2259_FixResetOnInstanceMehtodWithFlowCapture branch from 7bea59f to 82dd6bc Compare October 6, 2022 07:25
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title S2259: FP for fields not reset on invocation on this Fix S2259 FP: Reset fields on this invocation with flow captures Oct 6, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 12f8101 into master Oct 6, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Martin/S2259_FixResetOnInstanceMehtodWithFlowCapture branch October 6, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix S2259 FP: Reset fields on this invocation with flow captures
2 participants