Support new C#11 string types in CopyPasteTokenAnalyzer and TokenTypeAnalyzer #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csaba-sagi-sonarsource
force-pushed
the
čaba/raw-string-literal-token
branch
from
3311a61
to
9979b3d
Compare
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned csaba-sagi-sonarsource
costin-zaharia-sonarsource
requested changes
Oct 13, 2022
| @@ -40,7 +41,13 @@ protected override string GetCpdValue(SyntaxToken token) | |||
| { | |||
| return "$num"; | |||
| } | |||
| else if (token.IsAnyKind(SyntaxKind.StringLiteralToken, SyntaxKind.InterpolatedStringTextToken)) | |||
| else if (token.IsAnyKind(SyntaxKind.StringLiteralToken, | |||
| SyntaxKind.InterpolatedStringTextToken, | |||
There was a problem hiding this comment.
I see that we subscribe here to InterpolatedStringTextToken but the following are missing:
InterpolatedSingleLineRawStringStartTokenInterpolatedMultiLineRawStringStartToken
They are not needed?
There was a problem hiding this comment.
No, we only want to replace the "body" of the string with the $str. and not also the being and and tokens.
| public void Aaa() | ||
| { | ||
| var x = 42; | ||
| var interpolatedWithWhitespaceToken = $"This literal should be $str but the whitespace between interpolation will not: {x} {x}"; |
There was a problem hiding this comment.
As far as I can tell this message is misleading, the space is actually a string. See:
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned costin-zaharia-sonarsource
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned csaba-sagi-sonarsource
csaba-sagi-sonarsource
force-pushed
the
čaba/raw-string-literal-token
branch
from
944b5dd
to
b2b856e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned costin-zaharia-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.