Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE: Add NumberConstraint for literals #7171

Merged
merged 4 commits into from
May 4, 2023
Merged

SE: Add NumberConstraint for literals #7171

merged 4 commits into from
May 4, 2023

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Fixes #7140

This is currently based on 2 other PRs
Commit SE: Disable SymbolicValue cache for NumberConstraint doesn't need a review, it's in #7170

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Pavel/constant numbers SE: Add NumberConstraint for literals May 3, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource linked an issue May 3, 2023 that may be closed by this pull request
SE: Add NumberConstraint for literals #7140
Closed
Base automatically changed from Pavel/Equals to master May 3, 2023 15:05
Tim-Pohlmann
Tim-Pohlmann approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review May 4, 2023 06:13
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 9952536 into master May 4, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/ConstantNumbers branch May 4, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SE: Add NumberConstraint for literals
2 participants
@pavel-mikula-sonarsource @Tim-Pohlmann