Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S6668: Logging arguments should be passed to the correct parameter #8800

Merged
merged 12 commits into from
Feb 29, 2024
Merged

New rule S6668: Logging arguments should be passed to the correct parameter #8800

merged 12 commits into from
Feb 29, 2024

Conversation

costin-zaharia-sonarsource
Copy link
Member

Fixes #8765

@costin-zaharia-sonarsource costin-zaharia-sonarsource changed the title Add rspec + scafolding New rule S6668: Exceptions should be passed as the correct argument when logging Feb 26, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource marked this pull request as ready for review February 27, 2024 12:31
@costin-zaharia-sonarsource costin-zaharia-sonarsource marked this pull request as draft February 28, 2024 08:18
@costin-zaharia-sonarsource costin-zaharia-sonarsource marked this pull request as ready for review February 28, 2024 12:33
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource changed the title New rule S6668: Exceptions should be passed as the correct argument when logging New rule S6668: Logging arguments should be passed to the correct parameter Feb 28, 2024
zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The tests are very detailed. I added a comment on restructuring and a couple of polishing comments.

analyzers/its/sources/ManuallyAddedNoncompliantIssues.CS/IntentionalFindings/S6668.cs Outdated Show resolved Hide resolved
analyzers/rspec/cs/S6668.json Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LoggingArgumentsShouldBePassedCorrectly.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/LoggingArgumentsShouldBePassedCorrectly.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LoggingArgumentsShouldBePassedCorrectly.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/LoggingArgumentsShouldBePassedCorrectly.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LoggingArgumentsShouldBePassedCorrectly.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LoggingArgumentsShouldBePassedCorrectly.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LoggingArgumentsShouldBePassedCorrectly.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LoggingArgumentsShouldBePassedCorrectly.cs Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 4fe2a8b into master Feb 29, 2024
28 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costtin/S6668 branch February 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule S6668: Logging arguments should be passed to the correct parameter
2 participants
@costin-zaharia-sonarsource @zsolt-kolbay-sonarsource