Razor mappings: Ensure we check if the mapped span is valid

[costin-zaharia-sonarsource]

Related to #9288

[sonarcloud]

Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[martin-strecker-sonarsource]

I assume that in razor files, if mappedLineSpan.HasMappedPath is false, IsInSameFile(mappedLineSpan) is false as well. Therefore the mappedLineSpan.HasMappedPath check might be redundant. Can you confirm this? If so, I would remove

Suggested change

	&& (!GeneratedCodeRecognizer.IsRazor(token.SyntaxTree) || mappedLineSpan.HasMappedPath)
	&& IsInSameFile(mappedLineSpan)
	&& IsInSameFile(mappedLineSpan)

and add a comment about the mappedLineSpan.HasMappedPath being redundant.

[costin-zaharia-sonarsource]

You are right, but I would keep it since it is way faster to check this than to do string comparisons (although we cannot completely remove those).

So we reduce the data set a bit here, and later even more.

[martin-strecker-sonarsource]

LGTM