Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S6964 FP: Should not raise for reference properties in nullable context #9308

Merged
merged 4 commits into from
May 22, 2024
Merged

Fix S6964 FP: Should not raise for reference properties in nullable context #9308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5617ba
don't raise on strings
mary-georgiou-sonarsource May 21, 2024
eccb51d
don't raise for reference types in nullable context
mary-georgiou-sonarsource May 22, 2024
1893773
remove comment
mary-georgiou-sonarsource May 22, 2024
f57dfb9
apply comments
mary-georgiou-sonarsource May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ private static void CheckInvalidProperties(INamedTypeSymbol parameterType, Sonar

private static bool CanBeNull(ITypeSymbol type) =>
type is ITypeParameterSymbol { HasValueTypeConstraint: false }
|| (type.IsReferenceType && type.NullableAnnotation() != NullableAnnotation.NotAnnotated)
|| type.IsReferenceType
|| type.IsNullableValueType();

private static void GetAllDeclaredProperties(ITypeSymbol type, ConcurrentDictionary<ITypeSymbol, bool> examinedTypes, List<IPropertySymbol> declaredProperties)
Expand Down
7 changes: 6 additions & 1 deletion analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp8.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@ namespace NullableReferences
public class ModelUsedInController
{
#nullable enable
public string NonNullableReferenceProperty { get; set; } // Noncompliant
zsolt-kolbay-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
public string NonNullableReferenceProperty { get; set; } // Compliant - ASP.NET Core treats non-nullable reference types as if they were decorated with the [Required] attribute
public object AnotherNonNullableReferenceProperty { get; set; }
[Required] public string RequiredNonNullableReferenceProperty { get; set; }
public string? NullableReferenceProperty { get; set; }
public int ValueProperty { get; set; } // Noncompliant
public int? NullableValueProperty { get; set; }
#nullable disable
public string ReferenceProperty { get; set; }
public object AnotherReferenceProperty { get; set; }
public int? AnotherNullableValueProperty { get; set; }
}

public class DerivedFromController : Controller
Expand Down