Fix S6964 FP: Should not raise for reference properties in nullable context #9308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
requested changes
May 22, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp8.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp8.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
force-pushed
the
mary/S6964-FP-strings
branch
from
3fea67e
to
9423b57
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/S6964-FP-strings
branch
from
4e24132
to
eccb51d
Compare
mary-georgiou-sonarsource
changed the title
| @@ -23,24 +28,3 @@ public IActionResult Create(ModelUsedInController model) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| namespace CustomGenerics | |||
There was a problem hiding this comment.
Why were these test cases removed?
There was a problem hiding this comment.
Wrong push! I'll revert.
| @@ -7,11 +7,16 @@ namespace NullableReferences | |||
| public class ModelUsedInController | |||
| { | |||
| #nullable enable | |||
| public string NonNullableReferenceProperty { get; set; } // Noncompliant | |||
| public string NonNullableReferenceProperty { get; set; } | |||
There was a problem hiding this comment.
Suggested change
| public string NonNullableReferenceProperty { get; set; } | |
| public string NonNullableReferenceProperty { get; set; } // Compliant - ASP.NET Core treats non-nullable reference types as if they were decorated with the [Required] attribute |
zsolt-kolbay-sonarsource
approved these changes
May 22, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9284