Fix quality flaw: Use "require", immutable list, remove unused import (…

…#403)
SonarSource · Dec 13, 2023 · 9eadc7a · 9eadc7a
1 parent 5be4aaf
commit 9eadc7a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/...-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt b/...-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt
@@ -187,7 +187,7 @@ private fun checkIfExpressionHasParameter(
     first: KtExpression?,
     second: KtExpression?,
     klassParameters: List<KtParameter>,
-    methodParameters: MutableList<KtParameter>,
+    methodParameters: List<KtParameter>,
     map: MutableMap<KtParameter, Boolean>,
 ) {
     val parameter = findParameter(first, klassParameters) ?: return

diff --git a/sonar-kotlin-plugin/src/main/java/org/sonarsource/kotlin/plugin/KotlinPlugin.kt b/sonar-kotlin-plugin/src/main/java/org/sonarsource/kotlin/plugin/KotlinPlugin.kt
@@ -32,7 +32,6 @@ import org.sonarsource.kotlin.externalreport.detekt.DetektRulesDefinition
 import org.sonarsource.kotlin.externalreport.detekt.DetektSensor
 import org.sonarsource.kotlin.externalreport.ktlint.KtlintRulesDefinition
 import org.sonarsource.kotlin.externalreport.ktlint.KtlintSensor
-import org.sonarsource.kotlin.gradle.GRADLE_PROJECT_ROOT_PROPERTY
 import org.sonarsource.kotlin.gradle.KotlinGradleSensor
 import org.sonarsource.kotlin.surefire.KotlinResourcesLocator
 import org.sonarsource.kotlin.surefire.KotlinSurefireParser

diff --git a/sonar-kotlin-plugin/src/main/java/org/sonarsource/kotlin/plugin/linking/package-info.java b/sonar-kotlin-plugin/src/main/java/org/sonarsource/kotlin/plugin/linking/package-info.java
@@ -18,4 +18,4 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 @javax.annotation.ParametersAreNonnullByDefault
-package org.sonarsource.kotlin.api.frontend;
+package org.sonarsource.kotlin.plugin.linking;
diff --git a/sonar-kotlin-test-api/src/main/java/org/sonarsource/kotlin/testapi/DummyInputFile.kt b/sonar-kotlin-test-api/src/main/java/org/sonarsource/kotlin/testapi/DummyInputFile.kt
@@ -76,7 +76,7 @@ class DummyInputFile(val path: Path? = null) : InputFile {
         newRange(newPointer(startLine, startLineOffset), newPointer(endLine, endLineOffset))
 
     override fun selectLine(line: Int): TextRange {
-        if (line > lines.size) throw IllegalArgumentException("Line not in file")
+        require(line <= lines.size) { "Line not in file" }
         return newRange(line, 0, line, lines[line - 1].length)
     }