Fix resolving the custom environment variable to pass the sonar token #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Can conflicts be addressed so this can be merged? |
|
@fleetwoodstack sorry for the late response.. I somehow missed this PR. I have just rebased my PR on master. |
|
Hi, Thanks a lot for your contribution |
|
Hi @claire-villard-sonarsource I'm confused - this change is good to go so what's the risk of including the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently passing a custom environment variable to the orb that contains the Sonar token does not work due to incorrectly resolving the value. This PR addresses that problem.