SonarLint for Visual Studio 2017 plugin does not respect shared imports

[t03apt]

SonarLint for Visual Studio 2017 does not work well with shared imports.

I am using Directory.Build.props to import many code analyzers to all projects.
A custom .ruleset file is also specified there.
Here I am importing the other .ruleset generated by the SonarLint plugin.

SonarLint VS plugin does not recognize these shared imports.
When I click on Update in 'Test Explorer - Sonar Qube' window, it always creates needles rulesets for each projects. For example: \ClassLibrary1\ClassLibrary1.ruleset.
It also inserts needless PropertyGroups to .csproj files like

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
    <CodeAnalysisRuleSet>ClassLibrary1.ruleset</CodeAnalysisRuleSet>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <CodeAnalysisRuleSet>ClassLibrary1.ruleset</CodeAnalysisRuleSet>
  </PropertyGroup>

Note: I removed .sonarlint\TestSonarlint.slconfig from the example repository because it has some confidential information.

[t03apt]

SonarLint VS plugin also can't update <PackageReference Include="SonarAnalyzer.CSharp" Version="..." /> defined in Directory.Build.props.

[duncanp-sonar]

@t03apt agreed, SLVS doesn't work well if you have manually configured your solution.
SLVS is using VS extensibility interfaces to set the ruleset (IVSBuildPropertyStorage) and to update the NuGet packages (IVSPackageInstaller). Neither of these interfaces give much control over where the settings are stored (e.g. the IVSPackageInstaller always seems to update the main project file) so there may not be much we can do about updating a Directory.Build.props files instead.

However, we might be able to do a better job of detecting that a project is already configured and so not prompt to update.

Also, as of v4 SonarLint for Visual Studio won't add the NuGet package references to every project, Instead, it relies on the analyzers embedded in the VSIX, so that should be one less problem.

[duncanp-sonar]

FYI I've created #790 to track one of the specific issues raised in this ticket. That bug will be fixed in the next version of SLVS.

[duncanp-sonar]

FYI I've added a separate issue about adding unconditional ruleset property references: #805