Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQSCANGHA-26 Warning instead of failure for Maven/Gradle projects #117

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions .github/workflows/qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ jobs:
run: |
echo "Expected previous step to fail"
exit 1
failFastGradleTest:
dontFailGradleTest:
name: >
Fail fast on Gradle project
Don't fail on Gradle project
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -77,14 +77,13 @@ jobs:
SONAR_HOST_URL: http://not_actually_used
with:
projectBaseDir: ./test/gradle-project
- name: Previous should have failed
if: ${{ steps.runTest.outcome == 'success'}}
args: -Dsonar.scanner.dumpToFile=./output.properties
- name: Assert
run: |
echo "Expected previous step to fail"
exit 1
failFastMavenTest:
./test/assertFileExists ./output.properties
dontFailMavenTest:
name: >
Fail fast on Maven project
Don't fail on Maven project
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -98,11 +97,10 @@ jobs:
SONAR_HOST_URL: http://not_actually_used
with:
projectBaseDir: ./test/maven-project
- name: Previous should have failed
if: ${{ steps.runTest.outcome == 'success'}}
args: -Dsonar.scanner.dumpToFile=./output.properties
- name: Assert
run: |
echo "Expected previous step to fail"
exit 1
./test/assertFileExists ./output.properties
runAnalysisTest:
runs-on: ubuntu-latest
services:
Expand Down
8 changes: 4 additions & 4 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ if [[ -n "${SONAR_ROOT_CERT}" ]]; then
fi

if [[ -f "${INPUT_PROJECTBASEDIR%/}/pom.xml" ]]; then
echo "Maven project detected. You should run the goal 'org.sonarsource.scanner.maven:sonar' during build rather than using this GitHub Action."
exit 1
echo "WARNING! Maven project detected. Sonar recommends running the 'org.sonarsource.scanner.maven:sonar-maven-plugin:sonar' goal during the build process instead of using this GitHub Action
to get more accurate results."
fi

if [[ -f "${INPUT_PROJECTBASEDIR%/}/build.gradle" ]]; then
echo "Gradle project detected. You should use the SonarQube plugin for Gradle during build rather than using this GitHub Action."
exit 1
echo "WARNING! Gradle project detected. Sonar recommends using the SonarQube plugin for Gradle during the build process instead of using this GitHub Action
to get more accurate results."
fi

unset JAVA_HOME
Expand Down