fix coverage of CeService and TaskWsRequest

SonarSource · Aug 25, 2016 · 21f1eb8 · 21f1eb8
1 parent 37ba377
commit 21f1eb8
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/sonar-ws/src/main/java/org/sonarqube/ws/client/ce/CeService.java b/sonar-ws/src/main/java/org/sonarqube/ws/client/ce/CeService.java
@@ -70,7 +70,7 @@ public TaskTypesWsResponse taskTypes() {
    * @since 5.5
    */
   public WsCe.TaskResponse task(String id) {
-    return call(new GetRequest(path("task")).setParam("id", id), WsCe.TaskResponse.parser());
+    return task(TaskWsRequest.newBuilder(id).build());
   }
 
   public WsCe.TaskResponse task(TaskWsRequest taskWsRequest) {

diff --git a/sonar-ws/src/test/java/org/sonarqube/ws/client/ce/CeServiceTest.java b/sonar-ws/src/test/java/org/sonarqube/ws/client/ce/CeServiceTest.java
@@ -105,7 +105,7 @@ public void task_by_id_only() {
   }
 
   @Test
-  public void task() {
+  public void task_with_stacktrace_and_scanner_context() {
     underTest.task(TaskWsRequest.newBuilder("task_id")
         .withErrorStacktrace()
         .withScannerContext()
@@ -114,4 +114,24 @@ public void task() {
     assertThat(serviceTester.getGetRequest().getPath()).isEqualTo("api/ce/task");
     assertThat(serviceTester.getGetRequest().getParams()).containsOnly(entry("id", "task_id"), entry("additionalFields", "stacktrace,scannerContext"));
   }
+
+  @Test
+  public void task_with_scanner_context_only() {
+    underTest.task(TaskWsRequest.newBuilder("task_id")
+        .withScannerContext()
+        .build());
+
+    assertThat(serviceTester.getGetRequest().getPath()).isEqualTo("api/ce/task");
+    assertThat(serviceTester.getGetRequest().getParams()).containsOnly(entry("id", "task_id"), entry("additionalFields", "scannerContext"));
+  }
+
+  @Test
+  public void task_with_stacktrace_only() {
+    underTest.task(TaskWsRequest.newBuilder("task_id")
+        .withErrorStacktrace()
+        .build());
+
+    assertThat(serviceTester.getGetRequest().getPath()).isEqualTo("api/ce/task");
+    assertThat(serviceTester.getGetRequest().getParams()).containsOnly(entry("id", "task_id"), entry("additionalFields", "stacktrace"));
+  }
 }