Fix quality flaw

SonarSource · Mar 31, 2015 · f067291 · f067291
1 parent 0d0d869
commit f067291
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java b/server/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java
@@ -216,9 +216,10 @@ private void updateDebtSubCharacteristic(RuleUpdate update, Context context) {
   }
 
   private void updateDebtRemediationFunction(RuleUpdate update, Context context) {
+    Integer subChar = context.rule.getSubCharacteristicId();
     boolean noChar =
-      (context.rule.getDefaultSubCharacteristicId() == null && context.rule.getSubCharacteristicId() == null) ||
-        (context.rule.getSubCharacteristicId() != null && context.rule.getSubCharacteristicId().intValue() == RuleDto.DISABLED_CHARACTERISTIC_ID);
+      (context.rule.getDefaultSubCharacteristicId() == null && subChar == null) ||
+        (subChar != null && subChar.intValue() == RuleDto.DISABLED_CHARACTERISTIC_ID);
 
     DebtRemediationFunction function = update.getDebtRemediationFunction();
     if (noChar || function == null) {