Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sonar property sonar.search.host #124

Closed
wants to merge 3 commits into from

Conversation

schnatterer
Copy link
Contributor

In certain environments (e.g. OpenShift) you cannot bind to 127.0.0.1 or you can only bind to certain port ranges.
That's why we have the sonar.web.host, sonar.web.port, sonar.search.httpPort and sonar.search.port properties.
What's missing is a sonar.search.host. I don't see any other way to run the recent versions of SonarQube on such environments.

See also my question on stackoverflow.

@simonbrandhof
Copy link
Contributor

Thanks for the contribution. I think we should have a single property to declare ip address. There's no need to have different values for Elasticsearch and web server.
Options are:

  • reuse sonar.web.host
  • replace sonar.web.host by sonar.host (or sonar.address, which is less misleading IMO).
    WDYT ?

@simonbrandhof simonbrandhof self-assigned this Mar 6, 2015
@schnatterer
Copy link
Contributor Author

Hi @simonbrandhof,
thanks for your input. That's a good point, actually. Keeps it simpler.
On the other hand, configurations like "listen to any address for incoming web requests but use only a specific address for binding the search server" will not be possible when both addresses are read from the same property.

Either way, If we're not going for a specific sonar.search.host property, I'd prefer reusing sonar.web.host. Keeps backward compatibility.

@simonbrandhof
Copy link
Contributor

Ok. So we will go on with new property "sonar.search.host". Could you complete the pull request with the related documentation in conf/sonar.properties please ?

@schnatterer
Copy link
Contributor Author

Alright, I reverted to my initial commit. It contains a commented out line for sonar.search.host as well as a short description in sonar-application/src/main/assembly/conf/sonar.properties. I hope that's what you meant.

@simonbrandhof
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants