SONAR-9082 SONAR-9062 H2 and ES must use the correct network interface #1912
Conversation
simonbrandhof
force-pushed
the
feature/sb/address-already-in-used-in-tests
branch
from
1d68657
to
7053ab1
Compare
| @@ -110,7 +111,7 @@ Provider resolveProviderAndEnforceNonnullJdbcUrl(Props props) { | |||
| } | |||
|
|
|||
| private static String buildH2JdbcUrl(int embeddedDatabasePort) { | |||
| return "jdbc:h2:tcp://localhost:" + embeddedDatabasePort + "/sonar"; | |||
| return "jdbc:h2:tcp://" + InetAddress.getLoopbackAddress().getHostAddress() + ":" + embeddedDatabasePort + "/sonar"; | |||
There was a problem hiding this comment.
Small note here, with IPv6 is requiring the host to be separated with bracket (because : is used in IPv6 address)
There was a problem hiding this comment.
There was a problem hiding this comment.
in fact no, I won't add a dependency on guava for that. However I will fix the issue.
| assertThat(System2.INSTANCE.isOsWindows()).isEqualTo(SystemUtils.IS_OS_WINDOWS); | ||
| } | ||
|
|
||
| @Test | ||
| public void testIsJavaAtLeast17() throws Exception { | ||
| public void testIsJavaAtLeast17() { |
There was a problem hiding this comment.
Stupid question here: since SonarQube is now using Java8 and that classes won't be loaded by Java 7 or Java 6, does this test shouldn't be dropped ?
There was a problem hiding this comment.
Indeed, let's deprecate this method and return always true.
| Connector connector = newConnector(props, HTTP_PROTOCOL, "http"); | ||
| Connector connector = new Connector(HTTP_PROTOCOL); | ||
| connector.setURIEncoding("UTF-8"); | ||
| connector.setProperty("address", props.value("sonar.web.host", "0.0.0.0")); |
There was a problem hiding this comment.
Here we are supposing that we are using IPv4, not a big deal.
There was a problem hiding this comment.
This is the default value, as commented in sonar.properties. Users can use IPv6 host.
|
|
||
| import static java.lang.String.format; | ||
| import static java.util.Collections.list; | ||
| import static org.apache.commons.lang.StringUtils.isBlank; | ||
|
|
||
| public final class NetworkUtils { | ||
|
|
||
| private static final RandomPortFinder RANDOM_PORT_FINDER = new RandomPortFinder(); | ||
| private static final Set<Integer> ALREADY_ALLOCATED = new HashSet<>(); |
There was a problem hiding this comment.
This set will fill during all the tests in the same JVM so even if a port is available we won't be able to find an available port if the method is called more than ~64512 not a big deal for the time being.
There was a problem hiding this comment.
Exact. I will complete the javadoc.
…n resolving sonar.search.port=0
simonbrandhof
force-pushed
the
feature/sb/address-already-in-used-in-tests
branch
from
7053ab1
to
a6ca4c7
Compare
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
| */ | ||
| @Deprecated | ||
| public boolean isJavaAtLeast17() { |
There was a problem hiding this comment.
Do not forget to remove this deprecated code someday. 
because it always returns true. Java 6 is not supported at runtime.
simonbrandhof
force-pushed
the
feature/sb/address-already-in-used-in-tests
branch
from
a6ca4c7
to
41ff386
Compare
SONAR-9082 H2 must bind to localhost interface only
SONAR-9062 ES must bind to the interface defined by property "sonar.search.host"
when "sonar.search.port" has value "0"