Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONAR-11475 Check if url is relative before redirecting #3186

Merged
merged 2 commits into from Nov 16, 2018
Merged

SONAR-11475 Check if url is relative before redirecting #3186

merged 2 commits into from Nov 16, 2018

Conversation

gregaubert
Copy link
Member

No description provided.

@julienlancelot julienlancelot force-pushed the feature/SONAR-11475/fix branch 2 times, most recently from eaaa889 to 2ddcfe2 Compare November 14, 2018 12:01
@julienlancelot julienlancelot force-pushed the feature/SONAR-11475/fix branch 3 times, most recently from ff00827 to 5b4007e Compare November 14, 2018 14:16
stas-vilchik
stas-vilchik approved these changes Nov 14, 2018
View reviewed changes
server/sonar-web/src/main/js/apps/maintenance/main-view.js Outdated

setInterval(() => {
let returnTo = this.options.returnTo;
if (!returnTo || !isRelativeUrl(returnTo)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment: extract this to a function.

@julienlancelot julienlancelot merged commit 133e5c1 into branch-6.7 Nov 16, 2018
@julienlancelot julienlancelot deleted the feature/SONAR-11475/fix branch November 16, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrandhof simonbrandhof simonbrandhof approved these changes

@stas-vilchik stas-vilchik stas-vilchik approved these changes

Assignees

@julienlancelot julienlancelot

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@gregaubert @simonbrandhof @stas-vilchik @julienlancelot