Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new options to stop the processing sooner if too many queries were performed #382

Merged
merged 6 commits into from
Feb 2, 2022

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Feb 2, 2022

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)
  • Contributing implementation have been added/updated (for bugfix/feature)
  • Website documentation have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Docs (changes that affect the documentation)
  • Chore (anything else), please describe:

What is the current behaviour?

What is the new behaviour?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Closes #254


View rendered README.md
View rendered documentation/docs/02-getting-started/02-workflow-testing.mdx
View rendered documentation/docs/03-all-inputs.mdx
View rendered documentation/docs/06-issues/01-inputs/01-all-inputs.mdx
View rendered documentation/docs/06-issues/01-inputs/17-limit-api-queries-count-input.mdx
View rendered documentation/docs/10-statistics.mdx

@C0ZEN C0ZEN added enhancement 🚀 Add a new feature/enhancement merge-into-master 👑 Will create a PR from develop to master labels Feb 2, 2022
@C0ZEN C0ZEN self-assigned this Feb 2, 2022
@github-actions github-actions bot added documentation 📚 Improvements or additions to documentation test 🧪 Contains a change in a test file website 💻 Improvements or additions to website labels Feb 2, 2022
Before processing each issue, the workflow will check if the input is enabled.
If this is the case, the processing may stop if the statistics for queries are higher than the limit.
Closes #254
@C0ZEN C0ZEN force-pushed the feature/limit-processing-quantity branch from 403a627 to db5effb Compare February 2, 2022 21:10
@C0ZEN C0ZEN changed the title WIP: chore(intellij): add libraries for indexing feat: add new options to stop the processing sooner if too much queries were performed Feb 2, 2022
@C0ZEN C0ZEN changed the title feat: add new options to stop the processing sooner if too much queries were performed feat: add new options to stop the processing sooner if too many queries were performed Feb 2, 2022
@C0ZEN C0ZEN marked this pull request as draft February 2, 2022 21:12
Before processing each pull request, the workflow will check if the input is enabled.
If this is the case, the processing may stop if the statistics for queries are higher than the limit.
Closes #254
@C0ZEN C0ZEN marked this pull request as ready for review February 2, 2022 21:48
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #382 (0c3e94c) into develop (1cfb88c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #382   +/-   ##
========================================
  Coverage    99.80%   99.80%           
========================================
  Files          104      104           
  Lines         2042     2072   +30     
  Branches       178      184    +6     
========================================
+ Hits          2038     2068   +30     
  Misses           4        4           
Flag Coverage Δ
integration-issues 72.63% <85.29%> (+0.15%) ⬆️
integration-pull-requests 76.64% <85.29%> (+0.09%) ⬆️
unit 99.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/inputs/issues-inputs.service.ts 100.00% <ø> (ø)
src/core/inputs/pull-requests-inputs.service.ts 100.00% <ø> (ø)
src/core/inputs/inputs.enum.ts 100.00% <100.00%> (ø)
src/core/processing/abstract-processing.service.ts 100.00% <100.00%> (ø)
src/core/processing/issues/issues.service.ts 100.00% <100.00%> (ø)
.../processing/pull-requests/pull-requests.service.ts 100.00% <100.00%> (ø)

@codeclimate
Copy link

codeclimate bot commented Feb 2, 2022

Code Climate has analyzed commit 0c3e94c and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 4

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.8% (0.0% change).

View more on Code Climate.

@C0ZEN C0ZEN force-pushed the feature/limit-processing-quantity branch from a43a89e to 0c3e94c Compare February 2, 2022 22:05
@C0ZEN C0ZEN merged commit 0021c1e into develop Feb 2, 2022
@C0ZEN C0ZEN deleted the feature/limit-processing-quantity branch February 2, 2022 22:06
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📦 Added when a Github/npm release was made label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📚 Improvements or additions to documentation enhancement 🚀 Add a new feature/enhancement merge-into-master 👑 Will create a PR from develop to master released 📦 Added when a Github/npm release was made test 🧪 Contains a change in a test file website 💻 Improvements or additions to website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Limit the number of API calls for queries
1 participant