Don't do init_backup every time db:create is run because it might be …

…slow if there is a large database that already exists. This matters especially after changing the running instances (e.g. adding more app servers) because when you do ec2onrails:setup it will run db:create (harmless) on the existing db.

Added a TODO in create_database to do the backup then, but first we need to check for the existence of the db and exit if it exists.

gem/lib/ec2onrails/recipes.rb

@@ -53,7 +53,6 @@
 
   after "deploy:symlink", "ec2onrails:server:set_roles", "ec2onrails:server:init_services"
   after "deploy:symlink", "ec2onrails:server:purge_proxy_cache"
-  after "ec2onrails:db:create", "ec2onrails:db:init_backup"
 
   on :load do
     before "deploy:symlink", "ec2onrails:server:run_rails_rake_gems_install"

gem/lib/ec2onrails/recipes/db.rb

@@ -55,6 +55,9 @@
         puts "  * Pausing to give MySQL some time to start up..."
         sleep 20
 
+        # TODO run init_backup after creating the db. This might be slow, so we need to
+        # check if the db exists, and exit without doing any of this if it exists.
+
         run %{mysql -u root -e "drop database if exists test; flush privileges;"}
         # removing anonymous mysql accounts
         run %{mysql -u root -D mysql -e "delete from db where User = ''; flush privileges;"}
@@ -65,7 +68,7 @@
         run %{mysql -u root -e "create database if not exists \\`#{cfg[:db_name]}\\`;"}
         run %{mysql -u root -e "grant all on \\`#{cfg[:db_name]}\\`.* to '#{cfg[:db_user]}'@'%' identified by '#{cfg[:db_password]}';"}
         run %{mysql -u root -e "grant reload on *.* to '#{cfg[:db_user]}'@'%' identified by '#{cfg[:db_password]}';"}
-        run %{mysql -u root -e "grant super on *.* to '#{cfg[:db_user]}'@'%' identified by '#{cfg[:db_password]}';"}        
+        run %{mysql -u root -e "grant super on *.* to '#{cfg[:db_user]}'@'%' identified by '#{cfg[:db_password]}';"}
       end
 
       desc <<-DESC