Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea of versioning #398

Closed
kubeeek opened this issue Jul 24, 2020 · 4 comments
Closed

Idea of versioning #398

kubeeek opened this issue Jul 24, 2020 · 4 comments
Labels

Comments

@kubeeek
Copy link

kubeeek commented Jul 24, 2020

Hello.

I cannot grasp the idea of versioning in the sampctl. I wanted to develop a server at 0.3.DL and how should I handle it in the sampctl config? I mean, every option different than 0.3.7 gives errors about dependencies and docs does not specify it too clear I guess.

"runtime": {
		"version": "0.3.DL"
}

Example error:

$ sampctl package ensure
INFO: Downloading newest plugin because no version is specified. Consider specifying a version for this dependency.
INFO: Zeex/samp-plugin-crashdetect downloading plugin resource for windows
INFO: _/Godfather successfully ensured dependency files for github.com/Zeex/samp-plugin-crashdetect
INFO: Downloading newest plugin because no version is specified. Consider specifying a version for this dependency.
INFO: github.com/Zeex/samp-plugin-crashdetect downloading plugin resource for windows
WARN: failed to ensure plugin github.com/Zeex/samp-plugin-crashdetect failed to get plugin github.com/Zeex/samp-plugin-crashdetect from net: plugin does not provide binaries for target platform windows and version 0.3DL
@ADRFranklin
Copy link
Collaborator

Yes, this means that the repository does not have a release that is setup for 0.3DL. I would recommend asking the repo owners/maintainers to add a specific release for 0.3DL.

This was done on purpose to make sure people where getting the releases that matched their setup.

@kubeeek
Copy link
Author

kubeeek commented Jul 24, 2020 via email

@ADRFranklin
Copy link
Collaborator

You can always go back down to a previous version of sampctl for now. I'm sure I can make a quick patch version in the next few days to fallback if no version is provided.

@ADRFranklin ADRFranklin changed the title [question] idea of versioning Idea of versioning Jul 24, 2020
@Southclaws
Copy link
Owner

All binaries work on 0.3.DL except for plugins that mess with memory. There should be no restriction, I don't remember ever adding one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants