Fixing versionless link file read error on Windows #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File "pyasm\common\common.py", line 359, in relative_dir
TypeError: endswith first arg must be bytes or a tuple of bytes, not str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create versionless naming entries on
Windowswithpython3, an error is thrown onserver.add_fileon the corresponding snapshot. This is due to the fact that we are opening "link" files as binaries and comparing the content with unicode literals.File "pyasm\common\common.py", line 359, in relative_dir
TypeError: endswith first arg must be bytes or a tuple of bytes, not str