Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adapt new cluster stack convention #61

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

aniruddha2000
Copy link
Member

Adapt controller with runtime sdk

  • API change for hook
  • Control loop for new way of cluster addon
  • fix hook server
  • update packages

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@janiskemper janiskemper mentioned this pull request Feb 8, 2024
5 tasks
Base automatically changed from ani-syself/add-hook-server to addons February 14, 2024 09:39
@aniruddha2000 aniruddha2000 force-pushed the ani-syself/add-cluster-addon-api-change branch from f4cc026 to 5de1c73 Compare February 14, 2024 10:27
@janiskemper janiskemper marked this pull request as ready for review February 14, 2024 17:02
Adapt controller with runtime sdk

- API change for hook
- Control loop for new way of cluster addon
- fix hook server
- update packages

Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
@aniruddha2000 aniruddha2000 force-pushed the ani-syself/add-cluster-addon-api-change branch from 3bcf194 to d4bc766 Compare February 15, 2024 07:16
@janiskemper
Copy link
Member

let's merge this to addons branch without fixing all linting. Can be done later

@janiskemper janiskemper merged commit 799b36d into addons Feb 15, 2024
5 of 7 checks passed
@janiskemper janiskemper deleted the ani-syself/add-cluster-addon-api-change branch February 15, 2024 08:14
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants