New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates to conformance test for scs-0214-v1 #489

Closed

2 of 3 tasks

cah-hbaum opened this issue Feb 28, 2024 · 0 comments · Fixed by #558

Closed

2 of 3 tasks

Small updates to conformance test for scs-0214-v1 #489

cah-hbaum opened this issue Feb 28, 2024 · 0 comments · Fixed by #558

Assignees

Labels

Container enhancement SCS is continuously built and tested SCS-VP10

Contributor

cah-hbaum commented Feb 28, 2024 •

edited

Loading

We need to update the conformance test for scs-0214-v1 done in #486 , since there were some relevant but non-critical comments.

Remove "internal" config (Create conformance test for scs-0214-v1 #486 (comment) and Create conformance test for scs-0214-v1 #486 (comment))
The config used in the code is a duplication of the one used during the input. Either we remove it and require a config to be inputed or the "internal" config is narrowed down.
Introduce another source for labels-by-node list (Create conformance test for scs-0214-v1 #486 (review))
The labels-by-node list should be able to come from other sources and not only the get_k8s_cluster_labelled_nodes()
Think about the possibility to provide some scenarios to test this test

Definition of Done:

Test is updated with reference to the comments from Create conformance test for scs-0214-v1 #486
PR created
Changes have been reviewed and merged

The text was updated successfully, but these errors were encountered:

cah-hbaum added enhancement Container SCS is continuously built and tested SCS-VP10 labels

cah-hbaum self-assigned this

cah-hbaum mentioned this issue

SCS K8s cluster standardization SovereignCloudStack/issues#181

Closed

65 tasks

mbuechse mentioned this issue

Add scs-0210-v2 and scs-0214-v1 zuul checks SovereignCloudStack/k8s-cluster-api-provider#714

Merged

cah-hbaum added a commit that referenced this issue


          Updates to Node distribution test (#489)

cf15c19

- added a new input that enables testing the test by providing yaml files containing label information for different nodes
- added "test-example.yaml" containing an example for such a test file
- removed the internal config, since the normal config file is already provided and read in as a default

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum linked a pull request

that will close this issue

Updates to Node distribution test (#489) #558

Merged

cah-hbaum added a commit that referenced this issue


          Updates to Node distribution test (#489)

84a7d7a

- added a new input that enables testing the test by providing yaml files containing label information for different nodes
- added "test-example.yaml" containing an example for such a test file
- removed the internal config, since the normal config file is already provided and read in as a default

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Update test according to change requests (#489)

c60f895

@mbuechse had some change requests, that are tackled with this commit.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          fixup! Update test according to change requests (#489)

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Updates to Node distribution test (#489)

e876f34

- added a new input that enables testing the test by providing yaml files containing label information for different nodes
- added "test-example.yaml" containing an example for such a test file
- removed the internal config, since the normal config file is already provided and read in as a default

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Update test according to change requests (#489)

8630c60

@mbuechse had some change requests, that are tackled with this commit.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Updates to Node distribution test (#489)

02dc4e7

- added a new input that enables testing the test by providing yaml files containing label information for different nodes
- added "test-example.yaml" containing an example for such a test file
- removed the internal config, since the normal config file is already provided and read in as a default

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Update test according to change requests (#489)

e64a2fb

@mbuechse had some change requests, that are tackled with this commit.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

martinmo mentioned this issue

[EPIC] KaaS standards #615

Open

29 tasks

cah-hbaum added a commit that referenced this issue


          Updates to Node distribution test (#489)

3af8562

- added a new input that enables testing the test by providing yaml files containing label information for different nodes
- added "test-example.yaml" containing an example for such a test file
- removed the internal config, since the normal config file is already provided and read in as a default

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Update test according to change requests (#489)

@mbuechse had some change requests, that are tackled with this commit.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Updates to Node distribution test (#489)

06e2207

- added a new input that enables testing the test by providing yaml files containing label information for different nodes
- added "test-example.yaml" containing an example for such a test file
- removed the internal config, since the normal config file is already provided and read in as a default

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Update test according to change requests (#489)

3eb16be

@mbuechse had some change requests, that are tackled with this commit.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>

cah-hbaum added a commit that referenced this issue


          Updates to Node distribution test (#489) (#558)

a04755e

Updates to Node distribution test (#489)

- added a new input that enables testing the test by providing yaml files containing label information for different nodes
- added "test-example.yaml" containing an example for such a test file
- removed the internal config, since the normal config file is already provided and read in as a default
- Add additional test files
- Add pytest script and more scenarios
- Replace masterN with control-N in test data
- Streamline testdata
- Small fixes to the compliant to standard
- Some fixes and updates in order to be compliant with the testdata. Thanks to @martinmo.
- Use yaml.safe_load(…) instead of yaml.load(…, yaml.SafeLoader)
- Small pep-8 changes.
- @mbuechse had some change requests, that are tackled with this commit.

---------

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
Co-authored-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com>

cah-hbaum closed this as completed in #558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment