Update Go layer to reflect vim-go var name change #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vim-go renamed go_highlight_methods to go_highlight_function_calls recently to address confusion with the way the existing variable names behaved [1]. This change will re-enable the higlighting of function and method _invocations_. [1] fatih/vim-go#1557 (comment)
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on SpaceVim! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
vim-go renamed
go_highlight_methodstogo_highlight_function_callsrecently to address confusion with the way the existing variable names behaved. This change will re-enable the higlighting of function and method invocations, which is currently broken. Although I've decided to not use spacevim, I thought others would benefit from the fix.No tests are included as I don't see any existing framework to test the existing layer.