Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the exact branch for git rebase #1754

Merged
merged 1 commit into from
May 25, 2018

Conversation

bram2000
Copy link
Contributor

@bram2000 bram2000 commented May 25, 2018

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

The documentation contains a git command that fails with the error fatal: Needed a single revision invalid upstream 'upstream'. This is fixed by specifying the exact branch, rather than just the remote.

No test as this is purely a documentation change.

@bram2000 bram2000 requested a review from wsdjeg as a code owner May 25, 2018 09:02
@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #1754 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1754   +/-   ##
=======================================
  Coverage   26.55%   26.55%           
=======================================
  Files         249      249           
  Lines       12405    12405           
=======================================
  Hits         3294     3294           
  Misses       9111     9111

@wsdjeg wsdjeg merged commit a64bd39 into SpaceVim:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants